feat(OnboardingTooltip): add close with close button #6892
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Изменения
OnboardingTooltip
добавил параметрcloseBy
;TooltipBase
добавил параметрыcloseIconLabel
иonCloseIconClick
(вTooltip
пока игнорируем их, т.к. по задаче нужно только дляOnboardingTooltip
);Tooltip
, за одно, удалил дублирующийTooltipBase
код.Нюанс
Заметил, что сейчас в
OnboardingTooltip
проблемы с доступностью.overlay
полностью перекрывает всё, не кликнуть даже по содержимому тултипа, а такжеoverlay
это просто<div>
;UPD создал задачу #6893