Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create table components #6615

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

inomdzhon
Copy link
Contributor

@inomdzhon inomdzhon commented Feb 22, 2024


  • Unit-тесты
  • e2e-тесты
  • Дизайн-ревью
  • Документация фичи

Описание

Базовая версия таблиц, которая работает только как ячейки куда можно вставлять свои компоненты.

Стилизуются:

  • разделитель;
  • фон;
  • цвет шрифта в theader/tfooter.

Copy link
Contributor

github-actions bot commented Feb 22, 2024

size-limit report 📦

Path Size
JS 361.58 KB (+1.1% 🔺)
JS (gzip) 110.33 KB (+1.15% 🔺)
JS (brotli) 91.14 KB (+1.09% 🔺)
JS import Div (tree shaking) 1.43 KB (0%)
CSS 264.46 KB (+0.98% 🔺)
CSS (gzip) 34.8 KB (+1.24% 🔺)
CSS (brotli) 28.22 KB (+1.23% 🔺)

Copy link

codesandbox-ci bot commented Feb 22, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Feb 22, 2024

e2e tests

Playwright Report

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 82.48%. Comparing base (6b8e5c3) to head (2130b1e).

Files Patch % Lines
...ckages/vkui/src/components/TableCell/TableCell.tsx 87.80% 5 Missing ⚠️
...c/components/TableHeaderLabel/TableHeaderLabel.tsx 78.57% 3 Missing ⚠️
packages/vkui/src/lib/utils.ts 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6615      +/-   ##
==========================================
+ Coverage   82.43%   82.48%   +0.05%     
==========================================
  Files         339      348       +9     
  Lines       10395    10485      +90     
  Branches     3475     3500      +25     
==========================================
+ Hits         8569     8649      +80     
- Misses       1826     1836      +10     
Flag Coverage Δ
unittests 82.48% <88.88%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Feb 22, 2024

👀 Docs deployed

Commit 2130b1e

@github-actions github-actions bot added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Mar 1, 2024
@github-actions github-actions bot removed the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Mar 2, 2024
@github-actions github-actions bot added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Mar 10, 2024
@inomdzhon inomdzhon force-pushed the imirdzhamolov/research/Table-cmp branch from 4653c78 to 7c52f05 Compare March 15, 2024 14:38
@vkcom-publisher vkcom-publisher removed the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Mar 16, 2024
@inomdzhon inomdzhon added the no-stale Добавляет PR в исключения для автоматического закрытия label Mar 20, 2024
@inomdzhon inomdzhon force-pushed the imirdzhamolov/research/Table-cmp branch from 7c52f05 to 2130b1e Compare April 5, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-stale Добавляет PR в исключения для автоматического закрытия
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Draft][Feature]: компоненты таблиц
3 participants