Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tech: add SimpleGrid component #6233

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

BlackySoul
Copy link
Contributor

- [ ] Unit-тесты

- [ ] e2e-тесты

  • Дизайн-ревью

  • Документация фичи

- [ ] Гайд миграции

Описание

Добавление layout-компонента для создания responsive-гридов

@BlackySoul BlackySoul requested a review from a team as a code owner December 8, 2023 06:03
Copy link
Contributor

github-actions bot commented Dec 8, 2023

size-limit report 📦

Path Size
JS 349.07 KB (+0.27% 🔺)
JS (gzip) 106.66 KB (+0.3% 🔺)
JS (brotli) 88.14 KB (+0.39% 🔺)
JS import Div (tree shaking) 1.43 KB (0%)
CSS 260 KB (+0.47% 🔺)
CSS (gzip) 33.98 KB (+0.59% 🔺)
CSS (brotli) 27.6 KB (+0.61% 🔺)

Copy link

codesandbox-ci bot commented Dec 8, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 19896af:

Sandbox Source
VKUI TypeScript Configuration

Copy link
Contributor

github-actions bot commented Dec 8, 2023

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Dec 8, 2023

👀 Docs deployed

Commit 19896af

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (ec0858f) 81.14% compared to head (19896af) 81.09%.
Report is 70 commits behind head on master.

Files Patch % Lines
...ages/vkui/src/components/SimpleGrid/SimpleGrid.tsx 86.36% 3 Missing ⚠️
packages/vkui/src/lib/layouts/helpers.ts 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6233      +/-   ##
==========================================
- Coverage   81.14%   81.09%   -0.05%     
==========================================
  Files         324      325       +1     
  Lines       10091    10095       +4     
  Branches     3386     3391       +5     
==========================================
- Hits         8188     8187       -1     
- Misses       1903     1908       +5     
Flag Coverage Δ
unittests 81.09% <78.57%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BlackySoul BlackySoul self-assigned this Dec 11, 2023
@BlackySoul BlackySoul added this to the v6 milestone Dec 11, 2023
@github-actions github-actions bot added pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности and removed pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности labels Dec 19, 2023
@github-actions github-actions bot added pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности and removed pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности labels Dec 27, 2023
@BlackySoul BlackySoul added the no-stale Добавляет PR в исключения для автоматического закрытия label Dec 29, 2023
@inomdzhon inomdzhon modified the milestones: v6, v6.1.0 Jan 16, 2024
@inomdzhon inomdzhon modified the milestones: v6.1.0, v6.2.0 May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-stale Добавляет PR в исключения для автоматического закрытия
Projects
Status: 👀 In Review
Development

Successfully merging this pull request may close these issues.

None yet

2 participants