fix(TabbarItem): use single Tappable #5914
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7f8036d:
|
e2e tests |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5914 +/- ##
==========================================
+ Coverage 79.13% 79.18% +0.05%
==========================================
Files 312 315 +3
Lines 9957 10021 +64
Branches 3332 3349 +17
==========================================
+ Hits 7879 7935 +56
- Misses 2078 2086 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
👀 Docs deployed
Commit 7f8036d |
eugpoloz
force-pushed
the
eugpoloz/2743-TabbarItem-double-tab
branch
2 times, most recently
from
1bf6309
to
99d46f8
Compare
eugpoloz
changed the title
3 tasks
github-actions
bot
added
the
pr-needs-work
|
PR закрыт из-за отсутствия активности в течение последних 14 дней. Если это произошло по ошибке или изменения все ещё актуальны, откройте PR повторно. |
eugpoloz
added
no-stale
github-actions
bot
added
the
patch
w/ new pure-ish css Ripple
and update markup
eugpoloz
force-pushed
the
eugpoloz/2743-TabbarItem-double-tab
branch
from
99d46f8
to
fb4a90d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Чеклист
Unit-тестыe2e-тестыОписание
Зашла в TabbarItem в процессе приведения в порядок аутлайнов внутри FocusVisible, поняла, что нужен небольшой рефакторинг, чтобы все работало как надо.
Изменения
TabbarItem