Refactor completions to use cobras default completion command #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kangasta
force-pushed
the
refactor/cobra-default-completion
branch
from
436e6e4
to
12e2b5f
Compare
…cobra This removes custom bash completion logic and custom completion escape logic as that is not supperted by completion scripts cobra generates.
kangasta
force-pushed
the
refactor/cobra-default-completion
branch
from
12e2b5f
to
8b53aaa
Compare
|
Closing this as #204 was merged in. We can handle possible cleanups in a new MR when cobra supports whitespace in bash completions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #134