Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency @mdx-js/react to v2 #1322

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 1, 2022

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@mdx-js/react (source) 1.6.22 -> 2.0.0 age adoption passing confidence

Release Notes

mdx-js/mdx

v2.0.0

Compare Source

Welcome to MDX 2! See the of the website for everything:

Changelog since last RC ##### `@mdx-js/mdx`
@mdx-js/react
@mdx-js/loader
@mdx-js/esbuild
remark-mdx
#### New Contributors

Thanks @​redallen, @​lonyele, @​PaulieScanlon, @​pd4d10, @​Gowee, @​mskelton, @​ihupoo, @​remcohaszing, @​loreanvictor, @​ChrisChinchilla, @​glitteringkatie, @​mvasilkov, @​jablko, @​michaeloliverx, @​yordis, @​rodrez, @​imballinst, @​gaearon.

Full Changelog: mdx-js/mdx@v1.6.3...2.0.0


Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@vercel
Copy link

vercel bot commented Feb 1, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/unleash-team/unleash-docs/EDiQA4BXEaM3D4rqSceXJhTjBfTU
✅ Preview: Failed

@github-actions
Copy link

github-actions bot commented Feb 1, 2022

Coverage report

Total coverage

Status Category Percentage Covered / Total
🟢 Statements 91.39% 4732/5178
🟢 Branches 80.24% 723/901
🟢 Functions 86.63% 1108/1279
🟢 Lines 92.79% 5402/5822

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from 79083ee

@ivarconr
Copy link
Member

ivarconr commented Feb 2, 2022

@thomasheartman I think this fails because the website lock file us not update. Mind take a look?

@thomasheartman
Copy link
Contributor

thomasheartman commented Feb 3, 2022

@ivarconr Thanks for pinging me! It seems that the /website directory doesn't contain a yarn.lock file at all. I think adding that would be good, but I don't think it explains what's gone wrong here.

Instead, I think this may be because of a breaking change from v1.6.22 to v2.0.0. Looking at the logs, it looks like v2.0.0 changes the package structure:

Error:  Docusaurus Node/SSR could not render static page with path /user_guide/v4-whats-new because of following error:
TypeError: (0 , _mdx_js_react__WEBPACK_IMPORTED_MODULE_1__.mdx) is not a function
    at MDXContent (main:21754:1716)
    [...]
Warning:  {"moduleIdentifier":"/home/runner/work/unleash/unleash/website/node_modules/babel-loader/lib/index.js??ruleSet[1].rules[8].use[0]!/home/runner/work/unleash/unleash/website/node_modules/@docusaurus/mdx-loader/lib/index.js??ruleSet[1].rules[8].use[1]!/home/runner/work/unleash/unleash/website/node_modules/@docusaurus/plugin-content-docs/lib/markdown/index.js??ruleSet[1].rules[8].use[2]!/home/runner/work/unleash/unleash/website/docs/addons/addons.md","moduleName":"./docs/addons/addons.md","loc":"1:1304-1307","message":"export 'mdx' (imported as 'mdx') was not found in '@mdx-js/react' (possible exports: MDXContext, MDXProvider, useMDXComponents, withMDXComponents)","compilerPath":"client"}

Also, docusaurus explicitly supports mdx v1, as mentioned in their docs. I don't know if that's related or not, though. I couldn't find any issues on their repo about this.

Update: with a liiittle more research (checking out the mdx-js website, I'm more inclined to say that this is a straight update to mdx v2, and thus incompatible with docusaurus (for now).

I suggest we close this and ignore this update for now unless you've got other suggestions? Maybe a newer beta version deals with it?

@ivarconr
Copy link
Member

ivarconr commented Feb 3, 2022

thanks for showing the error. It fails because @mdx-js/react migrated to ESM modules, currently not used by docusaurus. We can close this for now.

@renovate
Copy link
Contributor Author

renovate bot commented Feb 3, 2022

Renovate Ignore Notification

As this PR has been closed unmerged, Renovate will ignore this upgrade and you will not receive PRs for any future 2.x releases. However, if you upgrade to 2.x manually then Renovate will reenable minor and patch updates automatically.

If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.

@renovate renovate bot deleted the renovate/major-mdx-monorepo branch February 3, 2022 09:29
@thomasheartman
Copy link
Contributor

Got it (and closed). In that case, it probably relates to this issue:

facebook/docusaurus#6520

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants