Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIRO-1647 Modifying Pick and Place pt. 4 to treat services like services #344

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

mrpropellers
Copy link
Contributor

Proposed change(s)

Part 4 of Pick and Place was publishing messages over a service topic using a standard ROS Publisher rather than our API for Services. It also seems to be broken in general due to actions not registering to the message registry. Modified project on both Unity and ROS side to use the Service API for service messages, and added some quality of life updates to the ROS node so starting it without an accompanying Niryo One param server doesn't lock up a user's terminal.

Useful links (GitHub issues, JIRA tickets, forum threads, etc.)

Addresses issue #333 and this forum post.

Types of change(s)

  • Bug fix

Testing and Verification

Ran nodes up to the point where they fail to connect to a Niryo One, which I don't have on hand.

Checklist

  • Ensured this PR is up-to-date with the dev branch
  • Created this PR to target the dev branch
  • Followed the style guidelines as described in the Contribution Guidelines
  • Added tests that prove my fix is effective or that my feature works
  • Updated the Changelog and described changes in the Unreleased section
  • Updated the documentation as appropriate

Other comments

@mrpropellers mrpropellers changed the title Modifying Pick and Place pt. 4 to treat services like services AIRO-1647 Modifying Pick and Place pt. 4 to treat services like services Jan 15, 2022
@unity-cla-assistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants