AIRO-1647 Modifying Pick and Place pt. 4 to treat services like services #344
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Part 4 of Pick and Place was publishing messages over a service topic using a standard ROS Publisher rather than our API for Services. It also seems to be broken in general due to actions not registering to the message registry. Modified project on both Unity and ROS side to use the Service API for service messages, and added some quality of life updates to the ROS node so starting it without an accompanying Niryo One param server doesn't lock up a user's terminal.
Useful links (GitHub issues, JIRA tickets, forum threads, etc.)
Addresses issue #333 and this forum post.
Types of change(s)
Testing and Verification
Ran nodes up to the point where they fail to connect to a Niryo One, which I don't have on hand.
Checklist
dev
branchdev
branchOther comments