Create TestPrinterExtruderTrains.py #19037
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
casperlamboo
reviewed
May 7, 2024
Comment on lines
+66
to
+67
| if file in ["fdmprinter.def.json", "fdmextruder.def.json"]: | ||
| continue |
There was a problem hiding this comment.
Instead of skipping checks for fdmprinter.def.json and fdmextruder.def.json we can also check if the visible is set to true. Only visible definitions will be presented in the front-end.
https://github.com/Ultimaker/Cura/blob/main/resources/definitions/fdmprinter.def.json#L11C1-L11C26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test that validates every printer is pointing to either an extruder definition or inherits from a printer with an extruder definition.
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: