Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Infill setting visibility (and improve descr.) #18775

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Sophist-UK
Copy link
Contributor

@Sophist-UK Sophist-UK commented Mar 31, 2024

Description

This fixes the Infill sub-settings visibility when you have no infill.

  1. Add enabled lines where needed to make infill settings disappear when Density is 0
  2. Amend enabled lines to hide when Line Distance is 0
  3. Amend description of Line Distance to give more details about the impact of overriding the calculated value.
  4. Merge multiplier = 2 options when calculating Line Distance.
  5. Indent Support Angle.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I have made this same update in my installation of Cura 5.6.0 and tested that the changes work.

Test Configuration:

  • Windows 10
  • Cura 5.6.0
  • File: C:\Program Files\UltiMaker Cura 5.6.0\share\cura\resources\definitions\fdmprinter.def.json

Checklist:

1. Add `enabled` lines where needed to make infill settings disappear when Density is 0
2. Amend `enabled` lines to hide when Line Distance is 0
3. Amend description of Line Distance to give more details about the impact of overriding the calculated value.
4. Merge multiplier = 2 options when calculating Line Distance.
@github-actions github-actions bot added the PR: Community Contribution 👑 Community Contribution PR's label Mar 31, 2024
@saumyaj3 saumyaj3 added the PR: Improving UI 🎨 Like better navigation arrows, fixing scroll bar bugs label Apr 2, 2024
@wawanbreton wawanbreton self-assigned this Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Community Contribution 👑 Community Contribution PR's PR: Improving UI 🎨 Like better navigation arrows, fixing scroll bar bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants