Update DisplayInfoOnLCD.py

[GregValiant]

Bug fix for "remaining_time".
Affected M118 and M73_time
Bug was pointed out in #18766

Description

This repairs a problem with M118 lines being added if "remaining_time" was not selected. The bug affected M118 and M73_time insertions.
There was a request to add the "A" and "P" parameters to the M118 lines as they might be required by Octoprint.
Adding M117 is now an option.

This fixes... OR This improves... -->

Type of change

• [ X] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Cura 5.7beta and 4.13.1

Test Configuration:

• Operating System: Win 10 Pro

Checklist:

• [ X] My code follows the style guidelines of this project as described in UltiMaker Meta and Cura QML best practices
• [X ] I have read the Contribution guide
• [ X] I have commented my code, particularly in hard-to-understand areas
• [ X] I have uploaded any files required to test this change

[GregValiant]

Most of these changes were requested by #18766 while other are because I'm unable to keep my fingers out of it.
The changes have missed 5.7.0 so I will move it back to active when I eventually quit fooling with it.

[GregValiant]

I see no reason why Remco and Casper have to be the only ones horrified by my coding style.

[HellAholic]

Could be a bit simplified either like below

Suggested change

	if add_m118_line:
	if add_m118_a1 and not add_m118_p0:
	m118_str = "M118 A1 "
	if add_m118_p0 and not add_m118_a1:
	m118_str = "M118 P0 "
	if add_m118_p0 and add_m118_a1:
	m118_str = "M118 A1 P0 "
	if add_m118_line:
	if add_m118_a1:
	m118_str += "A1 "
	if add_m118_p0:
	m118_str += "P0 "

Or, you can check for both conditions being true at the same time in the first if, then use elif for individual conditions.

[HellAholic]

elif variation, first checks for both being true, otherwise goes for the other conditions.

Suggested change

	if add_m118_a1 and not add_m118_p0:
	m118_str = m118_text.replace("M118 ","M118 A1 ")
	if add_m118_p0 and not add_m118_a1:
	m118_str = m118_text.replace("M118 ","M118 P0 ")
	if add_m118_p0 and add_m118_a1:
	m118_str = m118_text.replace("M118 ","M118 A1 P0 ")
	if add_m118_p0 and add_m118_a1:
	m118_str = m118_text.replace("M118 ","M118 A1 P0 ")
	elif add_m118_p0:
	m118_str = m118_text.replace("M118 ","M118 P0 ")
	elif add_m118_a1:
	m118_str = m118_text.replace("M118 ","M118 A1 ")

[HellAholic]

I see no reason why Remco and Casper have to be the only ones horrified by my coding style.

Did a quick check to share the horror :P But I'm not familiar enough with the code to make a full review on it.

[GregValiant]

Thanks for looking anyway.
I'll make changes locally until a full review. Maybe I can get by with just a single additional commit.