-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TT-7325] Enable fixed window rate limiter #6253
Conversation
PR Description updated to latest commit (1f9f0aa) |
API Changes --- prev.txt 2024-05-16 07:39:52.185815846 +0000
+++ current.txt 2024-05-16 07:39:49.045816523 +0000
@@ -5812,6 +5812,9 @@
GetOAuthTokensPurgeInterval returns purge interval for lapsed OAuth tokens.
type RateLimit struct {
+ // EnableFixedWindow enables fixed window rate limiting.
+ EnableFixedWindowRateLimiter bool `json:"enable_fixed_window_rate_limiter"`
+
// Redis based rate limiter with fixed window. Provides 100% rate limiting accuracy, but require two additional Redis roundtrip for each request.
EnableRedisRollingLimiter bool `json:"enable_redis_rolling_limiter"`
|
PR Review
Code feedback:
✨ Review tool usage guide:Overview: The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
See the review usage page for a comprehensive guide on using this tool. |
PR Code Suggestions
✨ Improve tool usage guide:Overview:
See the improve usage page for a comprehensive guide on using this tool. |
💥 CI tests failed 🙈git-stateall ok Please look at the run or in the Checks tab. |
1 similar comment
💥 CI tests failed 🙈git-stateall ok Please look at the run or in the Checks tab. |
💥 CI tests failed 🙈git-stateall ok Please look at the run or in the Checks tab. |
4d09ac6
to
081f3a9
Compare
081f3a9
to
59612cd
Compare
59612cd
to
2d2116e
Compare
Quality Gate passedIssues Measures |
User description
The PR enables a fixed window rate limiter from behind the dev build tag.
Type
enhancement
Description
EnableFixedWindowRateLimiter
setting fromconfig/development.go
as it seems to be restructured.EnableFixedWindowRateLimiter
inconfig/rate_limit.go
to centralize rate limiting configurations.Changes walkthrough
development.go
Remove Fixed Window Rate Limiter Setting from Development Config
config/development.go
EnableFixedWindowRateLimiter
setting.rate_limit.go
Introduce Fixed Window Rate Limiter Configuration
config/rate_limit.go
EnableFixedWindowRateLimiter
setting to enable fixed window ratelimiting.
is enabled.