Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DX-1345] Update config.go where possible for inclusive naming project #826

Merged
merged 3 commits into from
May 29, 2024
Merged

[DX-1345] Update config.go where possible for inclusive naming project #826

merged 3 commits into from
May 29, 2024

Conversation

dcs3spp
Copy link
Contributor

@dcs3spp dcs3spp commented May 16, 2024 •
edited

Description

Update config.go where possible for inclusive naming project

Related Issue

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If pulling from your own
    fork, don't request your master!
  • Make sure you are making a pull request against the master branch (left side). Also, you should start
    your branch off our latest master.
  • My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
  • I have updated the documentation accordingly.
  • Modules and vendor dependencies have been updated; run go mod tidy && go mod vendor
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • go fmt -s
    • go vet

@dcs3spp dcs3spp changed the title [DX-1332] Update config.go where possible for inclusive naming project [DX-1345] Update config.go where possible for inclusive naming project May 16, 2024
sredxny
sredxny approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@sredxny sredxny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@dcs3spp dcs3spp merged commit c8b9d7c into master May 29, 2024
28 checks passed
@dcs3spp dcs3spp deleted the dx-1332 branch May 29, 2024 11:30
@dcs3spp
Copy link
Contributor Author

dcs3spp commented May 29, 2024

/release to release-1.9

@tykbot tykbot
Copy link

tykbot bot commented May 29, 2024

Working on it! Note that it can take a few minutes.

tykbot bot pushed a commit that referenced this pull request May 29, 2024
@dcs3spp
update config.go where possible for inclusive naming project (#826)
dc168b1 
Co-authored-by: Simon Pears <[email protected]>
Co-authored-by: Sredny M <[email protected]>
(cherry picked from commit c8b9d7c)
@buger buger mentioned this pull request May 29, 2024
Merged
@tykbot tykbot
Copy link

tykbot bot commented May 29, 2024

@dcs3spp Succesfully merged PR

buger added a commit that referenced this pull request May 29, 2024
@buger @sredxny
Merging to release-1.9: update config.go where possible for inclusive…
464b241 
… naming project (#826)

update config.go where possible for inclusive naming project (#826)

Co-authored-by: Simon Pears <[email protected]>
Co-authored-by: Sredny M <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sredxny sredxny sredxny approved these changes

@caroltyk caroltyk caroltyk approved these changes

@mativm02 mativm02 Awaiting requested review from mativm02

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dcs3spp @sredxny @caroltyk