Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLO-106 Added index on status field for posts table #20181

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+17 −1
Open

SLO-106 Added index on status field for posts table #20181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
016773c
Added index on status field for posts table
vershwal May 9, 2024
ddf5cd4
Merge branch 'main' into indexForPostsTable
vershwal May 9, 2024
a0e5bd6
Merge branch 'main' into indexForPostsTable
vershwal May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 13 additions & 0 deletions ...re/server/data/migrations/versions/5.83/2024-05-09-09-28-44-add-status-index-for-posts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
// For information on writing migrations, see https://www.notion.so/ghost/Database-migrations-eb5b78c435d741d2b34a582d57c24253

const {createNonTransactionalMigration} = require('../../utils');
const {addIndex, dropIndex} = require('../../../schema/commands');

module.exports = createNonTransactionalMigration(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can simplify this by using createAddIndexMigration, just like

Ghost/ghost/core/core/server/data/migrations/versions/5.72/2023-10-31-11-06-00-members-created-attribution-id-index.js

Line 3 in 842290c

module.exports = createAddIndexMigration('members_created_events', ['attribution_id']);

async function up(knex) {
await addIndex('posts', ['status', 'type'], knex);
},
async function down(knex) {
await dropIndex('posts', ['status', 'type'], knex);
}
);
3 changes: 3 additions & 0 deletions ghost/core/core/server/data/schema/schema.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,9 @@ module.exports = {
show_title_and_feature_image: {type: 'boolean', nullable: false, defaultTo: true},
'@@UNIQUE_CONSTRAINTS@@': [
['slug', 'type']
],
'@@INDEXES@@': [
['status', 'type']
]
},
posts_meta: {
Expand Down
2 changes: 1 addition & 1 deletion ghost/core/test/unit/server/data/schema/integrity.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ const validateRouteSettings = require('../../../../../core/server/services/route
*/
describe('DB version integrity', function () {
// Only these variables should need updating
const currentSchemaHash = 'ccf3893bc3f8930f0d1188e646abda6d';
const currentSchemaHash = '59239ddd22c372654e57b33e4c31eb26';
const currentFixturesHash = 'a489d615989eab1023d4b8af0ecee7fd';
const currentSettingsHash = '5c957ceb48c4878767d7d3db484c592d';
const currentRoutesHash = '3d180d52c663d173a6be791ef411ed01';
Expand Down