Fixing tests

TryGhost · May 20, 2024 · 768919e · 768919e
1 parent bcf6406
commit 768919e
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 9 deletions.
diff --git a/ghost/admin/app/components/gh-nav-menu/footer-banner.hbs b/ghost/admin/app/components/gh-nav-menu/footer-banner.hbs
@@ -10,10 +10,10 @@
 {{/if}}
 
 {{#if (and this.showWhatsNew this.whatsNew.hasNew)}}
- {{#let this.whatsNew.entries.firstObject as |entry|}}
+ {{#let (get this.whatsNew.entries "0") as |entry|}}
  <div class="gh-sidebar-banner gh-whatsnew-toast">
  <button class="gh-sidebar-banner-close" type="button" {{on "click" this.dismissWhatsNewToast}}>&#xd7;</button>
- <button class="gh-sidebar-banner-container" type="button" {{on "click" (action "openWhatsNewFeatured")}}>
+ <button class="gh-sidebar-banner-container" type="button" {{on "click" (fn this.openWhatsNewFeatured)}}>
  <div class="gh-sidebar-banner-head">
  {{svg-jar "sparkle-fill" class="gh-sidebar-banner-icon gh-whatsnew-banner-icon"}}
  <span class="gh-sidebar-banner-subhead">What's new?</span>

diff --git a/ghost/admin/app/components/gh-nav-menu/footer.hbs b/ghost/admin/app/components/gh-nav-menu/footer.hbs
@@ -52,7 +52,7 @@
  <li class="divider" role="separator"></li>
  {{else}}
  <li>
- <button class="dropdown-item" tabindex="-1" data-test-nav="whatsnew" type="button" {{on "click" (action "openWhatsNew")}}>
+ <button class="dropdown-item" tabindex="-1" data-test-nav="whatsnew" type="button" {{on "click" (fn this.openWhatsNew)}}>
  What's new?
  {{#if this.whatsNew.hasNew}}
  <div class="flex-grow-1 flex justify-end">{{svg-jar "sparkle-fill" class="gh-whatsnew-banner-icon"}}</div>

diff --git a/ghost/admin/app/components/modals/featured-whats-new.hbs b/ghost/admin/app/components/modals/featured-whats-new.hbs
@@ -1,15 +1,15 @@
 <div class="modal-content">
- {{#let this.whatsNew.entries.firstObject as |entry|}}
+ {{#let (get this.whatsNew.entries "0") as |entry|}}
  <div>
  {{#if entry.feature_image}}
- <img class="mb5" src={{entry.feature_image}}>
+ <img class="mb5" src={{entry.feature_image}} alt="Feature image">
  {{/if}}
  <h2>{{entry.title}}</h2>
  {{#if entry.custom_excerpt}}
  <p>{{entry.custom_excerpt}}</p>
  {{/if}}
  <div class="flex justify-end">
- <button {{on "click" (action "closeFeaturedWhatsNew")}} class="mr-2">Dismiss</button>
+ <button {{on "click" (fn this.closeFeaturedWhatsNew)}} class="mr-2" type="button">Dismiss</button>
  <a href="{{entry.url}}" class="gh-btn"><span>Read on &rarr;</span></a>
  </div>
  </div>

diff --git a/ghost/admin/app/components/modals/whats-new-featured.hbs b/ghost/admin/app/components/modals/whats-new-featured.hbs
@@ -1,7 +1,7 @@
 <div class="modal-content">
- {{#let this.whatsNew.entries.firstObject as |entry|}}
+ {{#let (get this.whatsNew.entries "0") as |entry|}}
  {{#if entry.feature_image}}
- <img class="gh-whatsnew-featured-feature-image mb5" src={{entry.feature_image}}>
+ <img class="gh-whatsnew-featured-feature-image mb5" src={{entry.feature_image}} alt="Feature image — {{entry.title}}">
  {{/if}}
 
  <section class="gh-whatsnew-featured-container">

diff --git a/ghost/admin/app/components/modals/whats-new.hbs b/ghost/admin/app/components/modals/whats-new.hbs
@@ -4,7 +4,7 @@
  {{#each this.whatsNew.entries as |entry|}}
  <a class="gh-whatsnew-modal-entry" href={{entry.url}} target="_blank" rel="noopener noreferrer">
  {{#if entry.feature_image}}
- <img class="gh-whatsnew-modal-entry-featureimage" src={{entry.feature_image}}>
+ <img class="gh-whatsnew-modal-entry-featureimage" src={{entry.feature_image}} alt="Feature image — {{entry.title}}">
  {{/if}}
  <div class="gh-whatsnew-modal-entrycontent">
  <h2>{{entry.title}}</h2>