[DEV-230299] Review requestSignature code snippet for better readability #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renatodelpupo
requested review from
pedroabdenor,
andresguedes and
marcosrivereto
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
andresguedes
approved these changes
May 16, 2024
marcosrivereto
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The signature generation utility was reviewed. It was updated with a new approach aiming for more clarity on the steps.
Also, some DTO types were reviewed and it was included some linting updates (added Prettier configuration file and documents active formatting).
Relevant Commits
Requirements
Evidence
Not applicable.
Additional Information
https://trustly.atlassian.net/browse/DEV-230299