New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add three new Membership Inference attacks #2271
base: dev_1.17.0
Are you sure you want to change the base?
Conversation
@beat-buesser could you review my pull request and let me know if I have to make changes? I am new to the community and would like to add some more Confidentiality attacks. |
Signed-off-by: iamsh4shank <[email protected]>
Signed-off-by: iamsh4shank <[email protected]>
Signed-off-by: iamsh4shank <[email protected]>
Hi @iamsh4shank Thank you very much for your interest in ART and working on contributing new inference attacks! We will review this PR as soon as possible. |
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## dev_1.17.0 #2271 +/- ##
==============================================
- Coverage 85.62% 78.47% -7.16%
==============================================
Files 308 314 +6
Lines 27448 28399 +951
Branches 5044 5235 +191
==============================================
- Hits 23502 22285 -1217
- Misses 2667 4867 +2200
+ Partials 1279 1247 -32
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
Hi @iamsh4shank It looks like something failed in the new unit tests like unexpected arguments, etc. Could you please take a look? |
Yep sure will check and update the pull request soon |
Signed-off-by: iamsh4shank <[email protected]>
@beat-buesser could you please once run the CI/CD? |
Signed-off-by: iamsh4shank <[email protected]>
@beat-buesser I modified the commit, now it should fix almost all of the checks. I have a question here in this https://github.com/Trusted-AI/adversarial-robustness-toolbox/actions/runs/6130115176/job/16713558817?pr=2271, as here there is no installation for the cv2 that causes a few failures. So should I add cv2 in these files? |
Hi is there any update on this? |
json_path = json_path.parents[0] / f"{str(json_path.stem)}_{time}" f"{str(json_path.suffix)}" | ||
|
||
if overwrite_if_exists: | ||
append_if_exists = False |
Check notice
Code scanning / CodeQL
Unused local variable Note
|
||
""" | ||
|
||
from art.utils import check_and_transform_label_format |
Check notice
Code scanning / CodeQL
Unused import Note
import torch | ||
from torch.utils.data import TensorDataset, DataLoader | ||
from torchvision import transforms | ||
import time |
Check notice
Code scanning / CodeQL
Unused import Note
import time | ||
import datetime | ||
import numpy as np | ||
import copy |
Check notice
Code scanning / CodeQL
Unused import Note
Hi @iamsh4shank Sorry for the delay. We think the attacks are a great addition to ART's current inference attacks. We'll add a more detailed technical review soon. A few items I have noticed from a high-level review: could you please start adding unit tests for each attack and function in |
Yep sure, I will start working on the tests |
Description
Added three new types of membership inference attacks, these are as follows -
Type of change
Please check all relevant options.
Testing
Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.
Test Configuration:
Checklist