Fix race condition in ART configuration script #2132
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This addresses a race condition I found when running multiple scripts concurrently which all import ART. Namely, in the
config.py
file, since there were two separate checks forif os.path.exists(_config_path)
andif not os.path.exists(_config_path)
, the race condition occurs if another process creates the file at_config_path
in between those two checks, which can leave the_config
variable uninitialized. Hence, I changed those two separate checks into an if/else.Type of change
Please check all relevant options.
Testing
Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.
Checklist