This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
Feature: Identify prop #67
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Add new type definitions for identify
avanrielly
reviewed
Jun 8, 2018
| @@ -86,6 +93,17 @@ export default class FeatureFlagRenderer extends Component<Props, State> { | |||
| }); | |||
| } | |||
|
|
|||
| identify (ldClient: LdClientWrapperType) { | |||
There was a problem hiding this comment.
Probably should add a test for this
There was a problem hiding this comment.
Definitely, still trying to get these flow errors resolved.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current addition of
identifyvia the exportedutilsis a bit cumbersome to setup and doesn't really follow the same flow when working with the component helpers.In an attempt to improve upon this, an
identifyprop can be supplied to theFeatureFlagcomponent. Theidentifyprop takes in a user object, the same type defined here: https://github.com/TrueCar/react-launch-darkly#user--object-required. The main difference is you are not required to supply all of the properties, only the new properties you wish to re-identify the user to have.This is useful for use-cases where your state can change and you wish to re-identify the user seamlessly within your component. As the state changes, your feature flag components that depend upon it will get the updated prop passed down and will re-render as necessary.