Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core/Criteria: Implemented CriteriaType LearnAnyHeirloom #29976

Merged
merged 4 commits into from May 12, 2024
Merged

Core/Criteria: Implemented CriteriaType LearnAnyHeirloom #29976

merged 4 commits into from May 12, 2024

Conversation

BertiRean
Copy link
Contributor

@BertiRean BertiRean commented May 12, 2024 •
edited

Changes proposed:

  • Implemented Criteria for when you loot a Heirloom

Issues addressed:

Closes # (insert issue tracker number)

Tests performed:

  • Build Ok
    (Does it build, tested in-game, etc.)
  • Tested with .add command using items from Collection Journal.

Known issues and TODO list: (add/remove lines as needed)

  • [ ]
  • [ ]

@Shauren Shauren merged commit eaa76f0 into TrinityCore:master May 12, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Branch-master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BertiRean @Shauren