Scripts/The Black Morass: Bug fixing

[14shagov]

Changes proposed:

• The seventh and thirteenth waves start two minutes after you killed the boss of the sixth and eleventh wave respectively.
• Fixed issues with starting an event after Medivh's death.
• Replaced uint timers with EventMap
• Added a post-event at the end of the defense

Issues addressed:

Closes #27603

Tests performed:

build, tested in-game

[jackpoz]

Did you write all the code in this PR or was it copied from somewhere?

[14shagov]

Did you write all the code in this PR or was it copied from somewhere?

As for the post-event, I took the code from AzerothCore as a sample, but modified it to my liking. All the other changes I mentioned I wrote myself.

[acidmanifesto]

https://app.circleci.com/pipelines/github/TrinityCore/TrinityCore/13318/workflows/bef15d82-4779-405c-9633-ced8c54b03ed/jobs/41409/parallel-runs/0/steps/0-105?invite=true#step-105-72741_17

TempSummon isnt defined. How are you even getting this to compile and work?

[14shagov]

https://app.circleci.com/pipelines/github/TrinityCore/TrinityCore/13318/workflows/bef15d82-4779-405c-9633-ced8c54b03ed/jobs/41409/parallel-runs/0/steps/0-105?invite=true#step-105-72741_17

TempSummon isnt defined. How are you even getting this to compile and work?

My compiler is not as strict about checking for no includes.

[jackpoz]

As for the post-event, I took the code from AzerothCore as a sample, but modified it to my liking. All the other changes I mentioned I wrote myself.

Did you mention anywhere in your PR description ? Did you include anywhere credits to the author of the original code ?

[14shagov]

As for the post-event, I took the code from AzerothCore as a sample, but modified it to my liking. All the other changes I mentioned I wrote myself.

Did you mention anywhere in your PR description ? Did you include anywhere credits to the author of the original code ?

No, I didn't. This is new to me. I'd be glad if you could help me get it right. Should I just point out that I relied on someone else's code and author? Should I attach a link to the code?

[jackpoz]

Ideally, all code is written by you directly as a pull request submitter or in collaboration with someone who has agreed to submit the code to TC.

If you are copying code from other projects, then we should mention the original authors and check that the license is compatible with TC one, which is often a hassle that we would rather avoid.

[14shagov]

Okay, here are the links to the code I used:
1
2
3

Some are completely taken, some I changed. What do I do with this.