Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintain / upgrade pineone-client to v3 #1416

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hayzem
Copy link

@hayzem hayzem commented Apr 8, 2024

Description

pinecone-client library was outdated and didn't support the serverless deploymeyments. upgraded the library and applied the changes suggested here: https://canyon-quilt-082.notion.site/Pinecone-Python-SDK-v3-0-0-Migration-Guide-056d3897d7634bf7be399676a4757c7b#a21aff70b403416ba352fd30e300bce3

Related Issues

Solution and Design

Just maintaining the dependent libraray.

Test Plan

I have tested with Pinecone and it was okay. Since naming conventions applied to other vector databases it is also better to check those before merging.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • [x ] Maintaining

Checklist

  • My pull request is atomic and focuses on a single change.
  • I have read the contributing guide and my code conforms to the guidelines.
  • I have documented my changes clearly and comprehensively.
  • I have added the required tests.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@hayzem hayzem closed this Apr 8, 2024
@hayzem hayzem deleted the maintain/pinecone-client-upgrade branch April 8, 2024 18:32
@hayzem hayzem restored the maintain/pinecone-client-upgrade branch April 9, 2024 18:50
@hayzem hayzem reopened this Apr 9, 2024
@TransformerOptimus TransformerOptimus marked this pull request as ready for review April 22, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants