Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rails to last 6.1 #2706

Merged
merged 3 commits into from
Jun 6, 2024
Merged

Update Rails to last 6.1 #2706

merged 3 commits into from
Jun 6, 2024

Conversation

ZeiP
Copy link
Member

@ZeiP ZeiP commented Jan 3, 2022

Fixes #2463.

@ZeiP ZeiP force-pushed the update_rails branch 3 times, most recently from bf4a10e to eccf026 Compare January 3, 2022 23:41
@ZeiP
Copy link
Member Author

ZeiP commented Jan 3, 2022

Depends on #2463, which seems like there's something to do. Luckily Rails 6.0 will still be supported until June 1st 2023, so no real hurry here.

@ZeiP ZeiP force-pushed the update_rails branch 4 times, most recently from e7dd7f3 to 2d1075d Compare January 4, 2022 00:52
@ZeiP ZeiP marked this pull request as draft October 4, 2022 08:20
…ll requests for re-implementing with ActionMailbox are welcome.

Fixes #2463.
Copy link

gitguardian bot commented Jun 5, 2024

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11574321 Triggered Generic High Entropy Secret a94d4fa test/controllers/mailgun_controller_test.rb View secret
11574321 Triggered Generic High Entropy Secret a94d4fa test/controllers/mailgun_controller_test.rb View secret
11574321 Triggered Generic High Entropy Secret a94d4fa test/controllers/mailgun_controller_test.rb View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@ZeiP ZeiP marked this pull request as ready for review June 6, 2024 06:52
@ZeiP ZeiP merged commit 063c8bd into master Jun 6, 2024
4 of 5 checks passed
@ZeiP ZeiP deleted the update_rails branch June 6, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move from ActionMailer::Base.receive to Action Mailbox in processing inbound email
1 participant