Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[draft] Create operations server #921

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adam-singer
Copy link
Contributor

@adam-singer adam-singer commented May 16, 2024

Description

Please include a summary of the changes and the related issue. Please also
include relevant motivation and context.

Fixes # (issue)

Type of change

Please delete options that aren't relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please also list any relevant details for your test configuration

Checklist

  • Updated documentation if needed
  • Tests added/amended
  • bazel test //... passes locally
  • PR is contained in a single commit, using git amend see some docs

This change is Reviewable

@CLAassistant
Copy link

CLAassistant commented May 16, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@allada allada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 11 files at r1.
Reviewable status: 0 of 1 LGTMs obtained, and pending CI: Bazel Dev / ubuntu-22.04, asan / ubuntu-22.04, docker-compose-compiles-nativelink (20.04), docker-compose-compiles-nativelink (22.04), integration-tests (20.04), integration-tests (22.04), license/cla, macos-13, ubuntu-22.04, and 4 discussions need to be resolved


nativelink-config/examples/filesystem_cas.json line 175 at r1 (raw file):

  }],
  "global": {
    "max_open_files": 65000

nit: We don't change ulimit, so we probably don't want to do this.


nativelink-service/src/execution_server.rs line 50 at r1 (raw file):

use nativelink_scheduler::operations::{Operations as SchedulerOperations};

struct InstanceInfo {

nit: Needs renamed.


nativelink-service/src/execution_server.rs line 200 at r1 (raw file):

    }

    pub fn into_service(self) -> Server<ExecutionServer> {

nit: Lets rename this while we are here.


nativelink-service/src/execution_server.rs line 371 at r1 (raw file):

    async fn delete_operation(&self, request: Request<DeleteOperationRequest>) -> Result<Response<()>, Status> {
        unimplemented!()

nit: You'll want to return the Status of not implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants