feat(socketio/extensions): rework extensions and add an Extension decorator and an HttpExtension decorator
#309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Totodore
added
bug
This comment has been minimized.
This comment has been minimized.
Totodore
changed the title
Extension decorator and an HttpExtension decoratorExtension decorator and an HttpExtension decorator
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
| Report | Tue, May 21, 2024 at 13:38:12 UTC |
| Project | Socketioxide |
| Branch | feat-extensions-rework |
| Testbed | ubuntu-latest |
⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!
- Latency (latency)
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Latency | Latency Results nanoseconds (ns) |
|---|---|---|
| engineio_packet/decode/Decode packet binary b64 | ➖ (view plot) | 87.48 |
| engineio_packet/decode/Decode packet message | ➖ (view plot) | 40.12 |
| engineio_packet/decode/Decode packet noop | ➖ (view plot) | 34.58 |
| engineio_packet/decode/Decode packet ping/pong | ➖ (view plot) | 31.03 |
| engineio_packet/decode/Decode packet ping/pong upgrade | ➖ (view plot) | 36.04 |
| engineio_packet/encode/Encode packet binary b64 | ➖ (view plot) | 56.98 |
| engineio_packet/encode/Encode packet message | ➖ (view plot) | 33.96 |
| engineio_packet/encode/Encode packet noop | ➖ (view plot) | 33.70 |
| engineio_packet/encode/Encode packet open | ➖ (view plot) | 289.71 |
| engineio_packet/encode/Encode packet ping/pong | ➖ (view plot) | 32.33 |
| engineio_packet/encode/Encode packet ping/pong upgrade | ➖ (view plot) | 32.56 |
| extensions/concurrent_get | ➖ (view plot) | 6.91 |
| extensions/concurrent_get_inserts | ➖ (view plot) | 14.85 |
| extensions/concurrent_inserts | ➖ (view plot) | 21.07 |
| socketio_packet/decode/Decode packet ack on / | ➖ (view plot) | 282.36 |
| socketio_packet/decode/Decode packet ack on /custom_nsp | ➖ (view plot) | 303.93 |
| socketio_packet/decode/Decode packet binary ack (b64) on / | ➖ (view plot) | 512.42 |
| socketio_packet/decode/Decode packet binary ack (b64) on /custom_nsp | ➖ (view plot) | 522.08 |
| socketio_packet/decode/Decode packet binary event (b64) on / | ➖ (view plot) | 595.14 |
| socketio_packet/decode/Decode packet binary event (b64) on /custom_nsp | ➖ (view plot) | 614.65 |
| socketio_packet/decode/Decode packet connect on / | ➖ (view plot) | 62.87 |
| socketio_packet/decode/Decode packet connect on /custom_nsp | ➖ (view plot) | 79.13 |
| socketio_packet/decode/Decode packet event on / | ➖ (view plot) | 364.66 |
| socketio_packet/decode/Decode packet event on /custom_nsp | ➖ (view plot) | 380.23 |
| socketio_packet/decode/Decode packet event with ack on / | ➖ (view plot) | 357.17 |
| socketio_packet/decode/Decode packet event with ack on /custom_nsp | ➖ (view plot) | 378.20 |
| socketio_packet/encode/Encode packet ack on / | ➖ (view plot) | 115.67 |
| socketio_packet/encode/Encode packet ack on /custom_nsp | ➖ (view plot) | 120.08 |
| socketio_packet/encode/Encode packet binary ack (b64) on / | ➖ (view plot) | 314.74 |
| socketio_packet/encode/Encode packet binary ack (b64) on /custom_nsp | ➖ (view plot) | 320.09 |
| socketio_packet/encode/Encode packet binary event (b64) on / | ➖ (view plot) | 394.93 |
| socketio_packet/encode/Encode packet binary event (b64) on /custom_nsp | ➖ (view plot) | 416.24 |
| socketio_packet/encode/Encode packet connect on / | ➖ (view plot) | 52.31 |
| socketio_packet/encode/Encode packet connect on /custom_nsp | ➖ (view plot) | 55.02 |
| socketio_packet/encode/Encode packet event on / | ➖ (view plot) | 125.63 |
| socketio_packet/encode/Encode packet event on /custom_nsp | ➖ (view plot) | 130.41 |
| socketio_packet/encode/Encode packet event with ack on / | ➖ (view plot) | 124.34 |
| socketio_packet/encode/Encode packet event with ack on /custom_nsp | ➖ (view plot) | 130.03 |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the
ExtensionimplementationRwLock<HashMap>rather than aDashMapfor concurrent access.Clonethe returned data fromgetget_mutfnAdd
Extensionextractor.HttpExtensionextractor that extracts from theHttpRequest.Refactor
extractmodule into submodulesTodo
Resolves issue :