Masking workspace constants on frontend #9596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmithun4
requested changes
May 7, 2024
|
Deployment: https://tooljet-pr-9596.onrender.com |
shah21
previously approved these changes
May 8, 2024
Added data-cy for workspace constants components
Modified workspace constants cypress test cases
gsmithun4
approved these changes
May 14, 2024
Merged
gsmithun4
added a commit
that referenced
this pull request
May 16, 2024
* added dashboard URL in back to apps link * added decode function to replace symbols in the UI * Added condition so empty-folder UI is loaded * naming convention dashboardUrl * Added bump version changes * Added loader animation and updated utils (#9570) * Fix: Query duplication on version creation (#9588) * Added workspace_signup source (#9688) * design-fix (#9690) * Added a fix for the cropped postgresql icon issue (#9681) * source editor ui changes (#9667) * Workspace variables (#9616) * workspace-variable name * modified workspace variables info message * Added common data sources (#9468) * Added common data sources * Modified the Datasource context to display common data sources on page reload * Fixed Back to apps dashboard URL and added loader on Org Invitation Page (#9630) Co-authored-by: Muhsin Shah <[email protected]> * fixed the VerificationSucess Screen loader (#9584) * fixed the VerificationSucess Screen loader * added wrapper around loader * wrapper changes * fix for organization invite loader --------- Co-authored-by: Anantshree Chandola <[email protected]> Co-authored-by: gsmithun4 <[email protected]> * Masking workspace constants on frontend (#9596) * masking workspace constants on frontend * remove comment * update * added logic to verify constants keys used in codehinter * Add check for value type * update workspace constant permissions * Fix exitsing issues related to validation on code hinter * do not send encrypted value to fe * small updates * Add data-cy for workspace constants components * Modify workspace constants cypress test cases * fix value alignment --------- Co-authored-by: ajith-k-v <[email protected]> * Fox for export app with ToolJet DB (#9708) * Removed common data sources from search (#9728) * Removed common data sources from search * removed console logs * added padding to workspace-variable-text (#9724) * UI Updates (#9726) * UI updates * fix search bar borders and side bars border * update size of input box * FIx "<>&" UI errors (#9602) * added decode entity function * added decode functions to resolve <> naming * removed unnecessary fns * Moved decodeEntities function to helpers/util * Update frontend/src/_helpers/utils.js Co-authored-by: Midhun G S <[email protected]> --------- Co-authored-by: Midhun G S <[email protected]> * Added warning info for local data sources and added a svg to assets (#9704) * Added warning info for local data sources and added a svg to assets * converted output of isDataSourceLocal to boolean * fixed ui <>& symbol issues for tooltip and whitelabel (#9731) * Added a common fix for all cropped datasource icons on the global datasource page. (#9736) * Modified workspace constants cypress test cases (#9685) * UI updates (#9737) * removed localds migration link (#9743) * Styling fixes for UI comps (#9752) * removed documentation from text (#9754) * Styling updates (#9755) * UI updates * fix search bar borders and side bars border * update size of input box * ui updates * keep autocomplete off * add empty panel in query editor * style fixes * update * Add gap in between added key-value pairs --------- Co-authored-by: Rudra <[email protected]> Co-authored-by: Adish M <[email protected]> Co-authored-by: Rudhra Deep Biswas <[email protected]> Co-authored-by: gsmithun4 <[email protected]> Co-authored-by: kriks7iitk <[email protected]> Co-authored-by: Anantshree Chandola <[email protected]> Co-authored-by: ajith-k-v <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All workspace-constants values are resolved entirely on the backend. This centralized handling ensures consistency and
security across all points of access.
Except on the 'Mange workspace constants' page, values are not sent to the frontend. This is done to
ensure that the constants' values are not exposed during transmission or in client-side environments.
The GET APIs for workspace constants include a step to resolve the user's permissions to create, update, or delete
workspace constants along with a query param 'decryptValue' to ensure that only authorized users can access the
decrypted values of the constants and only on the 'Manage workspace constants' page.
Resolves #9412