Add @inlinable where SwiftUI has it #397
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDesiatov
approved these changes
Apr 9, 2021
There was a problem hiding this comment.
It will be hard to say what impact it has on performance until we have working benchmarks integrated with CI. But I don't see any harm in it, in fact it may make calculating diffs with the SwiftUI API easier. Either visually, or in an automated way, since attributes would match too.
|
this would be nice to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SwiftUI marks a lot of inits and View extension funcs
@inlinable, so I went in and did the same. Not sure if it will lead to any performance differences. Do you all think this worth it/something we should do?