Emit console.trace instead of throwing errors for non-critical stuff #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #7 The issue is here that a promise is usually expected, so I cannot just return Promise.ject() with an empty error, because this also results in a red error for the promise (with the worse error message "undefined"). Thus I've just made it to return a successful promise or undefined. I've also changed the similar uncritical error when tips should be shown according to gobal randomize, but no tip could be shown due to other factors, so there is no tip to be shown. Console.trace is BTW well-supported across browsers: https://developer.mozilla.org/en-US/docs/Web/API/console/trace#browser_compatibility
rugk
force-pushed
the
reduceErrorClutter
branch
from
49a26ae
to
6af2eef
Compare
|
/cc @tdulcet feel free to review |
tdulcet
reviewed
Aug 23, 2022
| @@ -322,15 +322,15 @@ export async function showRandomTip() { | |||
| * Shows the random tip only randomly so the user is not annoyed. | |||
| * | |||
| * @public | |||
| * @returns {Promise} | |||
| * @returns {Promise | undefined} | |||
There was a problem hiding this comment.
I believe the TypeScript compiler would complain about this...
Suggested change
| * @returns {Promise | undefined} | |
| * @returns {Promise<void> | void} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7
The issue is here that a promise is usually expected, so I cannot just return
Promise.ject() with an empty error, because this also results in a red error
for the promise (with the worse error message "undefined").
Thus I've just made it to return a successful promise or undefined.
I've also changed the similar uncritical error when tips should be shown
according to gobal randomize, but no tip could be shown due to other factors,
so there is no tip to be shown.
Console.trace is BTW well-supported across browsers:
https://developer.mozilla.org/en-US/docs/Web/API/console/trace#browser_compatibility