Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: show no random tip, because randomize did not pass is not an error #7

Open
tdulcet opened this issue Apr 23, 2021 · 1 comment · May be fixed by #10
Open

Error: show no random tip, because randomize did not pass is not an error #7

tdulcet opened this issue Apr 23, 2021 · 1 comment · May be fixed by #10
Labels
bug Something isn't working

Comments

@tdulcet
Copy link

tdulcet commented Apr 23, 2021

This is not an error and should not be output as one, as it makes finding actual errors in the console more difficult:

image

It is output nearly every time the options page or browser action popup is opened for all extensions that use this library, including the Awesome Emoji Picker.

@rugk
Copy link
Member

rugk commented Apr 23, 2021

Oh yes, feel free to change it.
I guess I wanted to have a proper Stacktrace. However, we can also accomplish that by using console.trace, so that’s the way I’d suggest…

@rugk rugk added the bug Something isn't working label Apr 23, 2021
rugk added a commit that referenced this issue Aug 22, 2022
Fixes #7

The issue is here that a promise is usually expected, so I cannot just return
Promise.ject() with an empty error, because this also results in a red error
for the promise (with the worse error message "undefined").

Thus I've just made it to return a successful promise or undefined.

I've also changed the similar uncritical error when tips should be shown
according to gobal randomize, but no tip could be shown due to other factors,
so there is no tip to be shown.

Console.trace is BTW well-supported across browsers:
https://developer.mozilla.org/en-US/docs/Web/API/console/trace#browser_compatibility
rugk added a commit that referenced this issue Aug 22, 2022
Fixes #7

The issue is here that a promise is usually expected, so I cannot just return
Promise.ject() with an empty error, because this also results in a red error
for the promise (with the worse error message "undefined").

Thus I've just made it to return a successful promise or undefined.

I've also changed the similar uncritical error when tips should be shown
according to gobal randomize, but no tip could be shown due to other factors,
so there is no tip to be shown.

Console.trace is BTW well-supported across browsers:
https://developer.mozilla.org/en-US/docs/Web/API/console/trace#browser_compatibility

Fixes #7
rugk added a commit that referenced this issue Aug 22, 2022
Fixes #7

The issue is here that a promise is usually expected, so I cannot just return
Promise.ject() with an empty error, because this also results in a red error
for the promise (with the worse error message "undefined").

Thus I've just made it to return a successful promise or undefined.

I've also changed the similar uncritical error when tips should be shown
according to gobal randomize, but no tip could be shown due to other factors,
so there is no tip to be shown.

Console.trace is BTW well-supported across browsers:
https://developer.mozilla.org/en-US/docs/Web/API/console/trace#browser_compatibility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants