Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some issues with typing generation when xs types are used #12

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix some issues with typing generation when xs types are used #12

wants to merge 5 commits into from

Conversation

zanemcca
Copy link

@zanemcca zanemcca commented Apr 11, 2019 •
edited

  • Array types that contain a namespace are mangled by the typing generator. This is fixed by explicitly keeping all array setup text prior to the namespace.
  • An xsd:decimal may have some typeData included which caused the typeData to be interpreted as a set of allowed values. The fix included catches all number types and makes sure they map to number

@zanemcca zanemcca marked this pull request as ready for review April 11, 2019 22:14
@zanemcca
Copy link
Author

@TimLuq Could I get some eyes on this fix?

@RafaelKr
Copy link

@TimLuq I would also appreciate to get this fix in. Just found out that I have type "integer" in my generated schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zanemcca @RafaelKr