Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cloud taskgraph support to Python Vamana's query() #375

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Add cloud taskgraph support to Python Vamana's query() #375

wants to merge 11 commits into from
+210 −66

Conversation

jparismorgan
Copy link
Contributor

@jparismorgan jparismorgan commented May 14, 2024 •
edited

What

Here we add cloud taskgraph support to Python Vamana's query(). We also start testing for BATCH Vamana ingestion.

Testing

  • Existing tests pass.
  • Vamana now runs the same cloud test as IVF Flat and passes.

@jparismorgan jparismorgan marked this pull request as ready for review May 30, 2024 15:13
NikolaosPapailiou
NikolaosPapailiou reviewed May 31, 2024
View reviewed changes
Copy link
Collaborator

@NikolaosPapailiou NikolaosPapailiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding support for query execution to be performed in a cloud taskgraph instead of the client could also be implemented in a generic way for all algorithms in index.py by wrapping query_internal and reopening the index inside the UDF.

apis/python/src/tiledb/vector_search/vamana_index.py
A specification for the amount of resources to use when executing using TileDB cloud
taskgraphs, of the form: {"cpu": "6", "memory": "12Gi", "gpu": 1}. Can only be used
in BATCH mode. Cannot be used alongside resource_class.
num_workers: int
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not performing distributed computation with many workers. It is only running the centralized query execution using cloud and not client resources.

Lets not have placeholder args and documentation when the implementation is not yet in place.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes, accident to include this, will remove.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikolaosPapailiou NikolaosPapailiou NikolaosPapailiou left review comments

@ihnorton ihnorton Awaiting requested review from ihnorton

@cainamisir cainamisir Awaiting requested review from cainamisir

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jparismorgan @NikolaosPapailiou