Python 3 + 2 fixes #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -27,6 +28,10 @@ NOTE: If you are unable to purchase the Armchair Analysis data, [Ben Dilday](htt | |||
| - pandas | |||
| - scikit-learn | |||
|
|
|||
| ## Node.js package requirements | |||
There was a problem hiding this comment.
is this useful given that these are already enumerated in package.json (and will be installed on npm install)?
There was a problem hiding this comment.
My thought is that parallels the list of python requirements above (which are listed in requirements.txt and installed on pip install) -- it wasn't clear to me from the code and the "This code currently requires Python 2.7" note above that Node.js was required to be installed in order to run -- since Python uses .json also now and there are no .js files in the main directory. But I could be persuaded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don’t know if you’re interested in releasing a Py3 compatible version for 2016 Fall, but the number of changes needed to make it work was actually rather small. Also updated README to indicate that underscore.js is required.