Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FreeBuds 3i support #16

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Add FreeBuds 3i support #16

wants to merge 13 commits into from

Conversation

mshpp
Copy link

@mshpp mshpp commented Nov 9, 2023

This branch adds support for Huawei FreeBuds 3i.

@TheLastGimbus TheLastGimbus mentioned this pull request Nov 13, 2023
Open
TheLastGimbus
TheLastGimbus reviewed Nov 15, 2023
View reviewed changes
assets/app_icons/freebuds-3i.png Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a Huawei's photo but scaled down? Iiiiii don't think i want this - one of reasons i hand-draw pictures is to avoid any copyright stuff 100%. I can draw it on my own later if you don't have capacity to do it

Copy link
Author

@mshpp mshpp Nov 27, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could reuse your image for FB 3i/Pro and do a release with 3i and FreeBuds Pro support, and then add the custom images later. The other PR for FreeBuds Pro also uses what seems to be an unaltered image from Huawei.

TheLastGimbus
TheLastGimbus reviewed Feb 23, 2024
View reviewed changes
lib/ui/pages/headphones_settings/hold_section.dart Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure anymore, but it has something to do with the way 3i handles ANC ON/OFF. I think that for 4i this change is functionally equivalent to the way it was before, and it adds the ability for 3i to work at all.

@TheLastGimbus
Copy link
Owner

TheLastGimbus commented Mar 6, 2024 •
edited

Could you check "allow pushes from maintainers" (or smth like that) ? I'm trying to rebase and merge this whole thing 👍

Btw I'm gonna be changing license to GPLv3, hope you cool with that 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheLastGimbus TheLastGimbus TheLastGimbus left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mshpp @TheLastGimbus