v9.13 #72
Draft
v9.13 #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rengels
suggested changes
Mar 24, 2024
| @@ -46,7 +46,7 @@ char codeVersion[] = "9.12.0"; // Software revision. | |||
| #include <Arduino.h> | |||
|
|
|||
| // All the required user settings are done in the following .h files: | |||
| #include "0_generalSettings.h" // <<------- general settings | |||
| #include "0_GeneralSettings.h" // <<------- general settings | |||
There was a problem hiding this comment.
the file is actually with lower case.
this might break on non-Windows.
| @@ -74,8 +75,15 @@ | |||
| - Connect a 100 - 470uF electrolytic cap and a 100nF tantalum or ceramic cap across pins 2 - 3 | |||
| */ | |||
| //#define RZ7886_DRIVER_MODE // An RZ7886 motor driver is used instead of a standard RC Crawler Type ESC. suitable for motors up to 370 size, for example WPL vehicles. | |||
| const uint16_t RZ7886_FREQUENCY = 500; // 500 Hz is recommended. It is not audible, if virtual engine sound is running. Higher frequencies may overheat the driver IC! | |||
| const uint8_t RZ7886_DRAGBRAKE_DUTY = 100; // 0 - 100%. 100% = max. brake power while standing still. 100% is recommended for crawlers. | |||
| uint16_t RZ7886_FREQUENCY = 500; // 500 Hz is recommended. It is not audible, if virtual engine sound is running. Higher frequencies may overheat the driver IC! | |||
There was a problem hiding this comment.
This variable is not configurable, right?
That's why the "const" is gone,
but can you also change the capitalization (lower case) if it's not longer a constant.
Actually, maybe you could do a:
#define RZ7886_FREQUENCY_INIT 500
and define the frequency variable in the .ino file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.