Skip to content
This repository has been archived by the owner on Sep 26, 2022. It is now read-only.

feat(MaterialApp): theme scrollbars #57

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

feat(MaterialApp): theme scrollbars #57

wants to merge 2 commits into from

Conversation

Florian-Schoenherr
Copy link
Collaborator

@Florian-Schoenherr Florian-Schoenherr commented Nov 7, 2020

squash (next time I will lint before commiting)
Closes: #56

@vercel
Copy link

vercel bot commented Nov 7, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/thecomputerm/svelte-materialify/3inqr3kep
✅ Preview: https://svelte-materialify-git-master.thecomputerm.vercel.app

@Florian-Schoenherr
Copy link
Collaborator Author

It doesn't work on vercel. And I don't know why.

@TheComputerM
Copy link
Owner

The vercel site is very buggy, I cannot scroll and the scrollbars look weird.

@Florian-Schoenherr
Copy link
Collaborator Author

Florian-Schoenherr commented Nov 7, 2020

Can't convert this to draft, and I guess I still need some time.

Found something: #root needs to be height: 100%.
This should just be mentioned first on the MaterialApp docs. If you want, I can try some different setups (using two MaterialApps, etc).
z-index on the aside is the culprit. Scrollbars don't have z-index (on chrome), so best idea for now:
put margin-left: <scrollbar-width> on the side-menu.
I will push a smaller scrollbar later.

Right now we have another problem:
side-menu
It's not updating with the new scrollbar, let me see what I can do.
Update:
cferdinandi/gumshoe#114 okay, gumshoe apparently only works on the "main scrollbar".
I mean, something like gumshoe which has the option to also specify the container on which scrolls happen would be nice.
We could leave this open until I get the time to find an alternative or anybody has a better idea.

@Florian-Schoenherr Florian-Schoenherr marked this pull request as draft February 4, 2021 21:42
@Florian-Schoenherr Florian-Schoenherr changed the title feat(MaterialApp): theme scrollbars, theme blank feat(MaterialApp): theme scrollbars Feb 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Theme Scrollbars
2 participants