Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tried new TESTS for the binomial_coefficient #10822

Merged
merged 5 commits into from
Oct 24, 2023
Merged

Tried new TESTS for the binomial_coefficient #10822

merged 5 commits into from
Oct 24, 2023

Conversation

imSanko
Copy link
Contributor

@imSanko imSanko commented Oct 22, 2023 •
edited

Describe your change:

Added few changes in the binomial_coefficient

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes Improve our test coverage #9943".

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Oct 22, 2023
@imSanko
Copy link
Contributor Author

imSanko commented Oct 23, 2023 •
edited

@cclauss can you review the tests and let me know about the same it

@cclauss
Copy link
Member

cclauss commented Oct 23, 2023 •
edited

Screenshot 2023-10-23 at 09 57 15

Click the Details button to the right of the ❌ below and then scroll to line 800.

If a test is failing that you believe should pass then comment it out adding # TODO: Fix this test

After this pull request has been merged, we can create a separate pull request to fix the TODOs.

@imSanko
Copy link
Contributor Author

imSanko commented Oct 24, 2023

Screenshot 2023-10-23 at 09 57 15

Click the Details button to the right of the ❌ below and then scroll to line 800.

If a test is failing that you believe should pass then comment it out adding # TODO: Fix this test

After this pull request has been merged, we can create a separate pull request to fix the TODOs.

Done

@cclauss
Copy link
Member

cclauss commented Oct 24, 2023

Done

Do it again.

@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 24, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 24, 2023
@cclauss cclauss merged commit 28f4c16 into TheAlgorithms:master Oct 24, 2023
3 checks passed
@imSanko imSanko mentioned this pull request Oct 25, 2023
Open
@imSanko
Copy link
Contributor Author

imSanko commented Oct 25, 2023

@cclauss thanks once again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve our test coverage
2 participants
@imSanko @cclauss