Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Boruvka algorithm + tests for Minimum Spanning Trees #2676

Closed
wants to merge 10 commits into from

Conversation

FranciscoThiesen
Copy link

Description of Change

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

@FranciscoThiesen
Copy link
Author

@Panquesito7 @realstealthninja reviews appreciated, thank you!

graph/boruvka.cpp Outdated Show resolved Hide resolved
graph/boruvka.cpp Outdated Show resolved Hide resolved
graph/boruvka.cpp Show resolved Hide resolved
@FranciscoThiesen
Copy link
Author

@realstealthninja I've addressed your suggestions. Also changed from int -> uint32_t in the union find, where negative values also don't make sense.

Let me know if there are any other issues.

Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contributions @Panquesito7 could you have a look as well?

graph/boruvka.cpp Outdated Show resolved Hide resolved
graph/boruvka.cpp Outdated Show resolved Hide resolved
FranciscoThiesen and others added 2 commits January 31, 2024 11:52
Adding comment on the self-test function

Co-authored-by: realstealthninja <[email protected]>
@FranciscoThiesen
Copy link
Author

@realstealthninja iterated on the last round of reviews!

@FranciscoThiesen
Copy link
Author

@realstealthninja can you approve the workflows?

Thank you,
Francisco

@FranciscoThiesen
Copy link
Author

@realstealthninja @Panquesito7 can you please approve the required workflows? I've addressed all the comments/suggested changes.

Thank you,
Francisco

@FranciscoThiesen
Copy link
Author

@FranciscoThiesen
Copy link
Author

@realstealthninja @Panquesito7 any updates? I'd like to merge this if possible

@FranciscoThiesen
Copy link
Author

@FranciscoThiesen
Copy link
Author

@realstealthninja @Panquesito7 can you kindly take a look? I have addressed all the changes requested and this is ready to merge. I can't initiate the checks and I am not currently a contributor.

Copy link
Contributor

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Author has not responded to the comments for over 2 weeks label May 10, 2024
Copy link
Contributor

Please ping one of the maintainers once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to ask for help in our Gitter channel or our Discord server. Thank you for your contributions!

@github-actions github-actions bot closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Author has not responded to the comments for over 2 weeks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants