Fix, Docs, Test: Fibonacci_fast (Renamed to Fibonacci_iterative) #2614
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The original algorithm does not calculate the nth fibonacci number, but rather the next fibonacci number after storing it in a static variable. Thus, I abstracted the looping part out of the code that you have to write upon application, into the function itself.
The "Test" in main does not really test anything, rather demonstrates what it does. Added actual unit tests with test cases.
The "Test" in main also does not calculate the nth fibonacci number, but rather the (n+1)th fibonacci number.
The maximum value that can be computed such that the result is less than UINT64_MAX is also incorrect because of the above error.
The file brief did not explain what it actually does properly.
Checklist
Notes:
Fixed bugs, added documentation, and unit tests for Fibonacci_fast (Renamed to Fibonacci_iterative to better reflect what it actually does).
For #2456.