Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove memory leak get_size_of_linked_list.cpp #2534

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: remove memory leak get_size_of_linked_list.cpp #2534

wants to merge 1 commit into from

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Sep 17, 2023

Description of Change

get_size_of_linked_list.cpp has a memory leak. This PR adds the function deleteList in order to fix it.

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

Removes memory leak in get_size_of_linked_list.cpp.

@vil02 vil02 marked this pull request as ready for review September 17, 2023 17:16
CarlosZoft
CarlosZoft approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@CarlosZoft CarlosZoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@vil02 vil02 force-pushed the memory_leak_in_get_size_of_linked_list_patch branch from 612db5b to c05ca74 Compare October 2, 2023 11:49
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Author has not responded to the comments for over 2 weeks label Dec 25, 2023
@vil02
Copy link
Member Author

vil02 commented Dec 25, 2023

@Panquesito7, @realstealthninja: please dont-close.

@github-actions github-actions bot removed the stale Author has not responded to the comments for over 2 weeks label Dec 26, 2023
@realstealthninja realstealthninja added the dont-close This issue/pull request shouldn't be closed label Jan 1, 2024
@vil02 vil02 force-pushed the memory_leak_in_get_size_of_linked_list_patch branch from c05ca74 to 8c9f3f1 Compare January 16, 2024 07:11
@vil02 vil02 force-pushed the memory_leak_in_get_size_of_linked_list_patch branch from 8c9f3f1 to 8e51010 Compare February 12, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlosZoft CarlosZoft CarlosZoft approved these changes

@realstealthninja realstealthninja realstealthninja approved these changes

@Panquesito7 Panquesito7 Awaiting requested review from Panquesito7 Panquesito7 is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
dont-close This issue/pull request shouldn't be closed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vil02 @CarlosZoft @realstealthninja