Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix/docs]: improve the Jump Game algorithm #2514

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Panquesito7
Copy link
Member

@Panquesito7 Panquesito7 commented Jul 26, 2023

Description of Change

  • Improve the Jump Game algorithm.
    • Fix segmentation fault.
    • Improved documentation.
    • Added missing namespace (greedy_algorithms).
    • Used proper filename with snake_case.
    • Added 3 extra tests.

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

@Panquesito7 Panquesito7 added the enhancement New feature or request label Jul 26, 2023
@Panquesito7

This comment was marked as outdated.

@Panquesito7 Panquesito7 marked this pull request as draft July 26, 2023 07:04
@Panquesito7 Panquesito7 marked this pull request as ready for review July 26, 2023 18:41
greedy_algorithms/jump_game.cpp Outdated Show resolved Hide resolved
greedy_algorithms/jump_game.cpp Outdated Show resolved Hide resolved
greedy_algorithms/jump_game.cpp Outdated Show resolved Hide resolved
Co-authored-by: Caeden Perelli-Harris <[email protected]>
Co-authored-by: Piotr Idzik <[email protected]>
@github-actions
Copy link
Contributor

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Author has not responded to the comments for over 2 weeks label Aug 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

Please ping one of the maintainers once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to ask for help in our Gitter channel or our Discord server. Thank you for your contributions!

@github-actions github-actions bot closed this Sep 4, 2023
@Panquesito7 Panquesito7 removed the stale Author has not responded to the comments for over 2 weeks label Jan 16, 2024
@Panquesito7 Panquesito7 reopened this Jan 16, 2024
@github-actions github-actions bot added the approved Approved; waiting for merge label Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved; waiting for merge enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants