Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make interface of NCRModuloP fail-safe #2469

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

fix: make interface of NCRModuloP fail-safe #2469

wants to merge 21 commits into from

Commits on Feb 12, 2024

  1. fix: set proper size of fac

    @vil02
    vil02 committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    d28c25c View commit details
    Browse the repository at this point in the history

  2. style: use std::size_t as a type of loop counter

    @vil02
    vil02 committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    5864c5a View commit details
    Browse the repository at this point in the history

  3. style: use uint64_t as a type of loop counter

    @vil02
    vil02 committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    81b3e7b View commit details
    Browse the repository at this point in the history

  4. fix: remove p from the argument list of NCRModuloP::ncr

    @vil02
    vil02 committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    21b2771 View commit details
    Browse the repository at this point in the history

  5. refactor: add utils namespace

    @vil02
    vil02 committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    69f48b9 View commit details
    Browse the repository at this point in the history

  6. refactor: use references in gcdExtended

    @vil02
    vil02 committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    e3b71c5 View commit details
    Browse the repository at this point in the history

  7. refactor: add NCRModuloP::computeFactorialsMod

    @vil02
    vil02 committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    4672baa View commit details
    Browse the repository at this point in the history

  8. style: make NCRModuloP::ncr const

    @vil02
    vil02 committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    d712dc8 View commit details
    Browse the repository at this point in the history

  9. test: reorganize tests

    @vil02
    vil02 committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    a13dff8 View commit details
    Browse the repository at this point in the history

  10. test: add missing test cases

    @vil02
    vil02 committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    af191b5 View commit details
    Browse the repository at this point in the history

  11. refactor: simplify logic

    @vil02
    vil02 committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    d29c96f View commit details
    Browse the repository at this point in the history

  12. style: make example object const

    @vil02
    vil02 committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    334d91e View commit details
    Browse the repository at this point in the history

  13. style: use auto

    @vil02
    vil02 committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    478edd5 View commit details
    Browse the repository at this point in the history

  14. style: use int64_t to avoid narrowing conversions

    @vil02
    vil02 committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    80b69db View commit details
    Browse the repository at this point in the history

  15. docs: update explanation why to import iostream

    @vil02
    vil02 committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    63e9d5b View commit details
    Browse the repository at this point in the history

  16. docs: remove p from docstr of NCRModuloP::ncr

    @vil02
    vil02 committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    e67ec3e View commit details
    Browse the repository at this point in the history

  17. docs: udpate doc-strs and add example()

    @vil02
    vil02 committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    94a475c View commit details
    Browse the repository at this point in the history

  18. Apply suggestions from code review 

    Co-authored-by: David Leal <[email protected]>
    @vil02 @Panquesito7
    vil02 and Panquesito7 committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    6bf8ccf View commit details
    Browse the repository at this point in the history

  19. dosc: add missing docs

    @vil02
    vil02 committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    c4d1f34 View commit details
    Browse the repository at this point in the history

  20. feat: display message when all tests pass 

    Co-authored-by: David Leal <[email protected]>
    @vil02 @Panquesito7
    vil02 and Panquesito7 committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    857e53d View commit details
    Browse the repository at this point in the history

  21. style: initialize NCRModuloP::p with 0 

    Co-authored-by: David Leal <[email protected]>
    @vil02 @Panquesito7
    vil02 and Panquesito7 committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    d44c270 View commit details
    Browse the repository at this point in the history