feat: added LeetCode problem 1,2 #2450

nageshnnazare · 2023-04-14T13:45:43Z

Created new directory for leetcode solutions, updated DIRECTORY.md and README.md

Description of Change

Checklist

Added description of change
Added file name matches File name guidelines
Added tests and example, test must pass
Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
Relevant documentation/comments is changed or added
PR title follows semantic commit guidelines
Search previous suggestions before making a new one, as yours may be a duplicate.
I acknowledge that all my contributions will be made under the project's license.

Notes:

Created new directory for leetcode solutions

leetcode/src/1.cpp

leetcode/src/2.cpp

leetcode/DIRECTORY.md

…leetcode-cpp

Panquesito7 · 2023-04-14T19:25:24Z

.github/workflows/leetcode_directory_writer.yml

+ - name: Write LeetCode DIRECTORY.md
+ run: |
+ python3 scripts/leetcode_directory_md.py 2>&1 | tee leetcode/DIRECTORY.md
+ git pull || true


AFAIK, this is not needed if we use fetch-depth in actions/checkout.
CC: @tjgurwara99.

Yeah this is not needed.

scripts/leetcode_directory_md.py

Co-authored-by: David Leal <[email protected]>

Panquesito7 · 2023-04-14T19:34:52Z

leetcode/README.md

+
+3. Do not provide a `main` function. Use the required standalone functions instead.
+4. Doxygen documentation isn't used in LeetCode solutions. Simple/small documentation or comments should be fine.
+5. Don't include libraries/headers such as `iostream`. Your file should be the solution to the problem only.


This might be needed to be added in the files to prevent CI failures, unless we ignore the files in the CI, which is not 100% recommended, though.
What do you suggest we do here? I suggest using libraries/headers in the files to prevent CI failures.

I was thinking whether this directory could be excluded from the CI, as in the case of the C repo leetcode directory. Else we also need to add a driver code for each problem along with some test cases. What are your thoughts?

We don't need a main function or self-tests for the CI to pass, we just need to make the function work as expected with its necessary libraries/headers.
AFAIK, the C repository doesn't ignore the leetcode directory in the CI.

Hi @Panquesito7
Updated the cpp files and the README file for these changes.

tjgurwara99 · 2023-04-14T22:37:30Z

.github/workflows/leetcode_directory_writer.yml

+ if: steps.commit-push.outputs.changes_detected == 'true'
+ run: |
+ gh pr create --base ${GITHUB_REF##*/} --head leetcode-directory-${{ github.sha }} --title 'docs: updating `leetcode/DIRECTORY.md`' --body 'Updated LeetCode directory (see the diff. for changes).'
+ gh pr merge --admin --merge --subject 'docs: updating `leetcode/DIRECTORY.md' --delete-branch


I'm personally against merging PR's through a workflow but I leave this decision to your @Panquesito7

Feel free to remove that part of the code so that we can check the PR to see if it is 100% fine.
Reviewing wouldn't take long as I'm always aware of incoming PRs in this repository. 🙂

Updated the yml file @Panquesito7 @tjgurwara99

* Updated the leetcode Readme.md file

…leetcode-cpp

tjgurwara99 · 2023-04-15T14:39:22Z

.github/workflows/leetcode_directory_writer.yml

+# when doing a git push
+name: leetcode_directory_writer
+on:
+ push:


Do we need this for every push? 🤔 I think it suffices to have this for a pull_request instead... What do you think @Panquesito7?

nageshnnazare · 2023-04-16T13:54:51Z

Hi @Panquesito7, @tjgurwara99
For problem 2, the CI is failing with the following warnings:

/home/runner/work/C-Plus-Plus/C-Plus-Plus/leetcode/src/2.cpp:29:9: warning: assigning newly created 'gsl::owner<>' to non-owner 'ListNode *' [cppcoreguidelines-owning-memory]
sum->next = new ListNode(val%10);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/runner/work/C-Plus-Plus/C-Plus-Plus/leetcode/src/2.cpp:35:9: warning: assigning newly created 'gsl::owner<>' to non-owner 'ListNode *' [cppcoreguidelines-owning-memory]
sum->next = new ListNode(carry);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

I guess it is because of the use of raw pointers instead of smart pointers. Is there a way to suppress this?

(This may require changing the definition of the ListNode struct, which is already defined by the platform)

struct ListNode {
int val;
std::unique_ptr next; // Use unique_ptr here
...
};

realstealthninja · 2023-04-22T15:11:40Z

Does this directory also fall under doxygen style guidelines?

Panquesito7 · 2023-04-26T17:14:19Z

Does this directory also fall under doxygen style guidelines?

I believe so. Not required, but if added, it's better, IMO.

Panquesito7 · 2023-04-26T17:15:31Z

Is there a way to suppress this?

It'd be better to use smart pointers, though.
I found this to convert raw to a smart pointer, it may help: https://www.sololearn.com/Discuss/1958592/how-can-i-replace-raw-pointers-with-smart-pointers

realstealthninja · 2023-04-27T00:08:49Z

Does this directory also fall under doxygen style guidelines?

I believe so. Not required, but if added, it's better, IMO.

Ah alright!

github-actions · 2023-05-27T00:10:51Z

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions · 2023-06-30T00:11:00Z

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions · 2023-07-07T00:12:13Z

Please ping one of the maintainers once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to ask for help in our Gitter channel or our Discord server. Thank you for your contributions!

feat: add LeetCode problem 1,2

c4e557f

Created new directory for leetcode solutions

nageshnnazare marked this pull request as draft April 14, 2023 14:02

nageshnnazare marked this pull request as ready for review April 14, 2023 14:02

Panquesito7 added the enhancement New feature or request label Apr 14, 2023

Panquesito7 reviewed Apr 14, 2023

View reviewed changes

leetcode/src/1.cpp Outdated Show resolved Hide resolved

leetcode/src/2.cpp Outdated Show resolved Hide resolved

Panquesito7 added 2 commits April 14, 2023 12:11

chore: apply suggestions from code review

505eb91

chore: apply suggestions from code review

7435ff1

Panquesito7 requested changes Apr 14, 2023

View reviewed changes

leetcode/DIRECTORY.md Outdated Show resolved Hide resolved

nageshnnazare added 3 commits April 14, 2023 18:48

feat: added github workflow action file for leetcode Directory.md file

ce1698f

Merge remote-tracking branch 'refs/remotes/origin/leetcode-cpp' into …

3f15ce2

…leetcode-cpp

Merge branch 'master' into leetcode-cpp

c994028

nageshnnazare marked this pull request as draft April 14, 2023 19:12

nageshnnazare added 2 commits April 14, 2023 19:17

added leetcode-python script for directory file generation

2a6c418

Merge remote-tracking branch 'refs/remotes/origin/leetcode-cpp' into …

29535e6

…leetcode-cpp

nageshnnazare marked this pull request as ready for review April 14, 2023 19:19

Panquesito7 reviewed Apr 14, 2023

View reviewed changes

Update scripts/leetcode_directory_md.py

9b65a20

Co-authored-by: David Leal <[email protected]>

Panquesito7 reviewed Apr 14, 2023

View reviewed changes

tjgurwara99 reviewed Apr 14, 2023

View reviewed changes

nageshnnazare added 3 commits April 15, 2023 05:45

feat: added header files to solutions to help CI

82e3e47

* Updated the leetcode Readme.md file

Merge remote-tracking branch 'refs/remotes/origin/leetcode-cpp' into …

06f5713

…leetcode-cpp

Merge branch 'TheAlgorithms:master' into leetcode-cpp

cd6145c

nageshnnazare marked this pull request as draft April 15, 2023 06:06

nageshnnazare added 2 commits April 15, 2023 06:13

feat: update the yml file for leetcode dir actions

079a161

Merge remote-tracking branch 'refs/remotes/origin/leetcode-cpp' into …

76c791b

…leetcode-cpp

nageshnnazare marked this pull request as ready for review April 15, 2023 06:15

feat: fix for CI warnings in 2.cpp

24379ec

tjgurwara99 reviewed Apr 15, 2023

View reviewed changes

feat: updated the yml and cpp files

c54849d

Panquesito7 mentioned this pull request Apr 28, 2023

feat: add well-formed parentheses generator #2445

Merged

8 tasks

github-actions bot added the stale Author has not responded to the comments for over 2 weeks label May 27, 2023

Panquesito7 removed the stale Author has not responded to the comments for over 2 weeks label May 30, 2023

github-actions bot added the stale Author has not responded to the comments for over 2 weeks label Jun 30, 2023

github-actions bot closed this Jul 7, 2023

Panquesito7 reopened this Jul 7, 2023

Panquesito7 requested a review from realstealthninja as a code owner July 7, 2023 05:07

Panquesito7 added dont-close This issue/pull request shouldn't be closed and removed stale Author has not responded to the comments for over 2 weeks labels Jul 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: added LeetCode problem 1,2 #2450

feat: added LeetCode problem 1,2 #2450

nageshnnazare commented Apr 14, 2023 •

edited

Panquesito7 Apr 14, 2023

tjgurwara99 Apr 14, 2023

Panquesito7 Apr 14, 2023

nageshnnazare Apr 14, 2023

Panquesito7 Apr 14, 2023

nageshnnazare Apr 15, 2023

tjgurwara99 Apr 14, 2023

Panquesito7 Apr 14, 2023

nageshnnazare Apr 15, 2023

tjgurwara99 Apr 15, 2023

nageshnnazare commented Apr 16, 2023 •

edited

realstealthninja commented Apr 22, 2023

Panquesito7 commented Apr 26, 2023

Panquesito7 commented Apr 26, 2023 •

edited

realstealthninja commented Apr 27, 2023

github-actions bot commented May 27, 2023

github-actions bot commented Jun 30, 2023

github-actions bot commented Jul 7, 2023

feat: added LeetCode problem 1,2 #2450

Are you sure you want to change the base?

feat: added LeetCode problem 1,2 #2450

Conversation

nageshnnazare commented Apr 14, 2023 • edited

Description of Change

Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nageshnnazare commented Apr 16, 2023 • edited

realstealthninja commented Apr 22, 2023

Panquesito7 commented Apr 26, 2023

Panquesito7 commented Apr 26, 2023 • edited

realstealthninja commented Apr 27, 2023

github-actions bot commented May 27, 2023

github-actions bot commented Jun 30, 2023

github-actions bot commented Jul 7, 2023

nageshnnazare commented Apr 14, 2023 •

edited

nageshnnazare commented Apr 16, 2023 •

edited

Panquesito7 commented Apr 26, 2023 •

edited