WIP: Add i3s support #7158
Open
WIP: Add i3s support #7158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljowen
force-pushed
the
add-i3s-support
branch
2 times, most recently
from
6525652
to
bb12991
Compare
|
|
na9da
reviewed
May 22, 2024
Comment on lines
+6
to
+13
| @traitClass({ | ||
| description: `Creates an I3S item in the catalog from an slpk.`, | ||
| example: { | ||
| type: "I3S", | ||
| name: "CoM Melbourne 3D Photo Mesh", | ||
| id: "some-unique-id" | ||
| } | ||
| }) |
There was a problem hiding this comment.
I didn't know this existed 💯
ljowen
force-pushed
the
add-i3s-support
branch
3 times, most recently
from
2560563
to
dc8249e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixes #6416
Test me
How should reviewers test this?
http://ci.terria.io/add-i3s-support/#share=s-6GOnlosN9giIE8La77FjvOGNl9l
Checklist
doc/.