Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci-deploy.sh: fix yarn run warning #7136

Merged
merged 1 commit into from
May 22, 2024

Conversation

pjonsson
Copy link
Contributor

@pjonsson pjonsson commented May 4, 2024

What this PR does

This removes the warning:

warning From Yarn 1.0 onwards, scripts don't require "--" for options to be forwarded. In a future version, any explicit "--" will be forwarded as-is to the scripts.

Test me

I should not have permissions to run the CI deploy job, so not sure how to test.

Checklist

  • There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
  • I've updated relevant documentation in doc/.
  • I've updated CHANGES.md with what I changed.
  • I've provided instructions in the PR description on how to test this PR.

This removes the warning:

warning From Yarn 1.0 onwards, scripts don't require "--" for options to be forwarded. In a future version, any explicit "--" will be forwarded as-is to the scripts.
@pjonsson pjonsson mentioned this pull request May 21, 2024
4 tasks
Copy link
Collaborator

@na9da na9da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pjonsson - Looks good, thanks for the PR.

@na9da na9da merged commit 8da7546 into TerriaJS:main May 22, 2024
6 checks passed
@pjonsson pjonsson deleted the fix-yarn-run-warning branch May 22, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants