Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix module warnings in 'gulp docs' #7135

Merged
merged 1 commit into from
May 31, 2024
Merged

Conversation

pjonsson
Copy link
Contributor

@pjonsson pjonsson commented May 4, 2024

What this PR does

Add the bufferutil and utf-8-validate
modules to remove the warnings when
running yarn gulp docs.

Test me

Not sure how to test this, but the screen full of yellow warnings about not being able to find modules when running yarn gulp docs is no longer present with this PR.

Checklist

  • There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
  • I've updated relevant documentation in doc/.
  • I've updated CHANGES.md with what I changed.
  • I've provided instructions in the PR description on how to test this PR.

Add the bufferutil and utf-8-validate
modules to remove the warnings when
running yarn gulp docs.
Copy link
Collaborator

@na9da na9da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pjonsson!

Fixes the following warnings:
image

@na9da na9da merged commit efed69a into TerriaJS:main May 31, 2024
6 checks passed
@pjonsson pjonsson deleted the fix-jsdom-warnings branch May 31, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants