Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add region poperty for working bucket #262

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add region poperty for working bucket #262

wants to merge 2 commits into from

Conversation

aantonw
Copy link

@aantonw aantonw commented Aug 5, 2017

This should fix #215 and #253

NitriKx
NitriKx reviewed Aug 5, 2017
View reviewed changes
Copy link
Member

@NitriKx NitriKx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! I think the working bucket region should not be required (for compatibility with the previous configurations). So if this value is unspecified, the working bucket takes the same region than the first billing bucket.

@aantonw
Copy link
Author

aantonw commented Aug 5, 2017

Ah, backward compatibility. Have updated the PR.

NitriKx added a commit that referenced this pull request Aug 29, 2017
@NitriKx
Merge branch 'bugfix/us-east-1-endpoint' of https://github.com/aanton…
7f74cdb 
…w/ice #262 into integration
@NitriKx NitriKx added this to the v1.1.3 milestone Sep 5, 2017
@NitriKx NitriKx self-assigned this Sep 5, 2017
@NitriKx NitriKx removed their assignment Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NitriKx NitriKx NitriKx left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1.3
Development

Successfully merging this pull request may close these issues.

By default Ice fails to use S3 on eu-central-1
2 participants
@aantonw @NitriKx