Allow either file-based or command-line AWS credentials #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 4, 2015 15:31
…ration file ($ICE_HOME/ice.properties). In our environment, we want those credentials in the ice.properties files, plus it lets you stick everything in a .war for serving up by tomcat
…ICE_HOME definitions for the AWS credentials, first preference is given to those on the command line.
…g if properties are set or not
|
ice-pull-requests #64 SUCCESS |
…been added which causes the startup to fail with a NullPointerException. in our environment we do not need the reservation info
|
ice-pull-requests #70 SUCCESS |
… we get more than an ugly NullPointer exception
Revert "comment out reservationService.init() - a new reservaration type has been added which causes the startup to fail with a NullPointerException. in our environment we do not need the reservation info" This reverts commit 11824b46941c47a77a8b45fcaba631f4a65f4f26.
|
ice-pull-requests #71 SUCCESS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #49 and it's being used without issue in our environment.