Feature/remove main thread queries #3827
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace database.getDao calls with direct dao calls
Replace database.getDao calls with direct dao calls
HalfAPum
force-pushed
the
feature/remove-main-thread-queries
branch
from
e6805e8
to
875d247
Compare
|
@HalfAPum can you please address static code analysis issues https://github.com/TeamAmaze/AmazeFileManager/pull/3827/checks?check_run_id=13839338151 |
|
There are bunch of errors in build and test cases. Please check them as well, if facing any issue do write we'll help check the issue there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I removed allowMainThreadQueries from databases initializations.
I checked that all dao function calls executes on IO thread.
I converted All Dao And Helper classes from Java to Kotlin.
I also made sure that same amount of tests passed after my changes as before them.
Issue tracker
Closes #3826
Automatic tests
Manual tests
Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug./gradlew spotlessCheck