Removed url decoder in getPath #3596
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
getPathmethod performs url decoding on the stored path but url decoding is not idempotent and there is no way to distinguish between url encoded and non-url encoded string. The original code suggests the class may accept url encoded string so there might be additional things to fix.Issue tracker
Fixes #3560
Automatic tests
Manual tests
Done
Device: Resizable
OS: API Level 33
Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug./gradlew spotlessCheck