fix issue #3245 #3251
Open
fix issue #3245 #3251
+21
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmmanuelMess
requested changes
Apr 10, 2022
| }); | ||
| googleThread.start(); | ||
| try{ | ||
| googleThread.join(); |
There was a problem hiding this comment.
No joining threads in main thread
There was a problem hiding this comment.
Any suggestions? I can't find a way to change it.
|
please fix #3262 with this as well |
EmmanuelMess
requested changes
Apr 22, 2022
| @@ -81,7 +81,7 @@ class MainActivityActionMode(private val mainActivityReference: WeakReference<Ma | |||
| hideOption(R.id.share, menu) | |||
| hideOption(R.id.openwith, menu) | |||
| if (mainActivity.mReturnIntent) showOption(R.id.openmulti, menu) | |||
| // hideOption(R.id.setringtone,menu); | |||
| // hideOption(R.id.setringtone,menu); | |||
There was a problem hiding this comment.
Don't leave commented code.
| @@ -466,7 +466,7 @@ public String getParentName() { | |||
|
|
|||
| /** | |||
| * Whether this object refers to a directory or file, handles all types of files | |||
| * | |||
| * Warning: Can't be used directly in UI/main thread | |||
There was a problem hiding this comment.
This should be a @WorkerThread annotation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3245
Issue tracker
Automatic tests
Manual tests
Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug./gradlew spotlessCheckArray out of index bug fix
While I fixing this bug I found another bug in removing the hidden files. If you remove more than one file at one time, you will find the hiddenFiles array's index will get wrong. I found that the index was not updated at the time of deletion. So I added in the source code that every delete must be reindexed. If you do not add this, you will end up with an array out of bounds or removing the wrong file when you remove hidden files multiple times.