Explicit MIME type declaration on querying available packages for opening files #3020
+24
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As noted by Android Studio on the use of
android.permission.QUERY_ALL_PACKAGES
permission, use<queries>
with explicitly defined action and MIME type instead. This looks safer (minimal permission principle), and also reduces possibility of unrelated apps from popping up in the list of available apps.Additionally:
application/vnd.sqlite3
android:exported
attribute to<activity>
s in AndroidManifest.xml where the activity is not necessary to exportrar
toFileUtils.COMPRESSED_FILE_EXTENSIONS
to fix problem that opening a RAR file using Amaze does not load up theCompressedExplorerFragment
Manual tests
Device: Pixel 2 emulator
OS: Android 11
Device: Fairphone 3
OS: LineageOS 16.0 (9.0)
Device: Pixel 2 emulator
OS: Android 6.0
CompressedExplorerFragment
for viewing contents inside the archiveBuild tasks success
Successfully running following tasks on local:
./gradlew assembledebug
./gradlew spotlessCheck